reef-pi :: An opensource reef tank controller based on Raspberry Pi.

[Ranjib]

I ran into this when creating kivy-reef – /read returns the uncalibrated reading. To obtain the calibrated reading, you need to call /api/phprobes/{id}/readings and use the last item in the list (i.e. the most recent reading).

I need to get back to this.. this is very inconvenient, we can just add an option in the read api to optionally get the calibrated valued. in fact i think we should return calibrated values unless explicitly raw value is requested.

 

[iamdan]

That would be awesome if you can do it! As like with the HA addon it has issues trying to read the latest ph from the readings api as compared to /read since it’s just one value listed

Between that and the graph hiccup I mentioned in GitHub when is it likely an update will come out that will fix this stuff? Just asking

 

[iamdan]

I need to get back to this.. this is very inconvenient, we can just add an option in the read api to optionally get the calibrated valued. in fact i think we should return calibrated values unless explicitly raw value is requested.

Would this change/fix then mean that /read would then by default get the calibrated reading?

 

[Ranjib]

Would this change/fix then mean that /read would then by default get the calibrated reading?

no. we wont break api, at least not in minor versions,. if we do break api, we'll call this out. I dont intend to break the api, i was thinking of adding an optional calibrated=true parameter in the read api. that will allow the new use case without breaking the old use case

 

[NXE]

no. we wont break api, at least not in minor versions,. if we do break api, we'll call this out. I dont intend to break the api, i was thinking of adding an optional calibrated=true parameter in the read api. that will allow the new use case without breaking the old use case

If you are thinking about publishing a new version of the API, could I put in a request for a way to get the state of an ATO – i.e. whether the float switch/optical level sensor etc. is in contact or not? The 'state' value is available via Prometheus and can be used to display the status of level sensors in Grafana, but I could not see any why to query this via the API.

This is what I have set up in Grafana and it would be great if I could achieve the same in KivyReef via the API: